k-space/kube
12
1
Fork 3
Code Issues 66 Pull Requests Wiki Activity

logging: added deployment namespace #4

Closed
dos4dev wants to merge 1 commits from restore_syslog_ingestion_support into master
pull from: restore_syslog_ingestion_support
merge into: :master
Conversation 1 Commits 1 Files Changed 1
+5
dos4dev commented 2022-10-08 18:06:49 +00:00
Member
Copy Link
Copy Source
No description provided.
lauri was assigned by dos4dev 2022-10-08 18:06:50 +00:00
dos4dev added 1 commit 2022-10-08 18:06:50 +00:00
logging: added deployment namespace 73e5a9d7c1
lauri commented 2022-10-11 06:16:34 +00:00
Owner
Copy Link
Copy Source

Please don't define namespaces in manifests, this can easily result in cascaded deletion of everything inside the namespace.

Since most resources here are managed by Argo please use Argo application definition to add namespaces. Argo has CreateNamespace sync option for this.

https://git.k-space.ee/k-space/kube/src/branch/master/argocd/applications/harbor.yml#L17

Please don't define namespaces in manifests, this can easily result in cascaded deletion of everything inside the namespace. Since most resources here are managed by Argo please use Argo application definition to add namespaces. Argo has `CreateNamespace` sync option for this. https://git.k-space.ee/k-space/kube/src/branch/master/argocd/applications/harbor.yml#L17
👍 1
dos4dev closed this pull request 2022-10-20 06:59:01 +00:00

Pull request closed

This pull request cannot be reopened because the branch was deleted.
Sign in to join this conversation.
Reviewers
No Reviewers
Labels
Clear labels
new app
shiny
disposal
Liability in safety, usability, space, or upkeep. It doesn't provide enough meaningful historical value (museum) nor personal interest.
 enchancement
Improving the existing
 greenlit
The stars have aligned: Orders have arrived, plan has been laid, only hands are needed. Just do it!
upkeep
Subjects of maintenance
bounty
10€
probably needs most of a visit dedicated to the task https://wiki.k-space.ee/en/about/task-bounties
bounty
20€
about a whole day or two to the task https://wiki.k-space.ee/en/about/task-bounties
bounty
5€
https://wiki.k-space.ee/en/about/task-bounties
bounty
package
See milestone, bounty for completing all issues.
No labels
Milestone
No items
No Milestone
Projects
Clear projects
No projects
Assignees
Clear assignees
akpall (Allen-Kristjan Päll) arti (Arti Zirk) artur (Artur Kerge) dos4dev (Oleksii Danyliuk) eaas (Erki Aas) erki (Erki Naumanis) kkuusk (Kristjan Kuusk) lauri (Lauri Võsandi) madis (Madis Mägi) plaes (Priit Laes) rasmus (Rasmus Kallas) sander (Sander Trumm) savva (Savva)
No Assignees lauri
2 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: k-space/kube#4