k-space
/
kube
9
1
Fork 1
Code Issues 17 Pull Requests Projects Activity

logging: added deployment namespace #4

Closed
dos4dev wants to merge 1 commits from restore_syslog_ingestion_support into master
pull from: restore_syslog_ingestion_support
merge into: k-space:master
Conversation 1 Commits 1 Files Changed 1 +5
dos4dev commented 2022-10-08 18:06:49 +00:00
Member
Copy Link
No description provided.
lauri was assigned by dos4dev 2022-10-08 18:06:50 +00:00
dos4dev added 1 commit 2022-10-08 18:06:50 +00:00
lauri commented 2022-10-11 06:16:34 +00:00
Owner
Copy Link

Please don't define namespaces in manifests, this can easily result in cascaded deletion of everything inside the namespace.

Since most resources here are managed by Argo please use Argo application definition to add namespaces. Argo has CreateNamespace sync option for this.

https://git.k-space.ee/k-space/kube/src/branch/master/argocd/applications/harbor.yml#L17

Please don't define namespaces in manifests, this can easily result in cascaded deletion of everything inside the namespace. Since most resources here are managed by Argo please use Argo application definition to add namespaces. Argo has `CreateNamespace` sync option for this. https://git.k-space.ee/k-space/kube/src/branch/master/argocd/applications/harbor.yml#L17
👍 1
dos4dev closed this pull request 2022-10-20 06:59:01 +00:00

Pull request closed

This pull request cannot be reopened because the branch was deleted.
Sign in to join this conversation.
Reviewers
No reviewers
Labels
Clear labels
No items
No Label
Milestone
Clear milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
No Assignees
lauri
2 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: k-space/kube#4
No description provided.
Delete Branch "restore_syslog_ingestion_support"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?