k-space/logmower-shipper
10
0
Fork 0
Code Issues 1 Pull Requests Packages Projects Activity

add TODOs from gitea issues

Browse Source
This commit is contained in:
rasmus 2022-11-03 12:42:59 +02:00
parent 55d47f30ec
commit f920d03bc8
2 changed files with 3 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
cmd/logmower.go
View File

@ -53,6 +53,7 @@ var App = &cli.App{
Description: "Collect and ship kubernetes logs", Description: "Collect and ship kubernetes logs",
// Usage: "rubykana <input>", // Usage: "rubykana <input>",
// TODO: #2: yaml
Flags: []cli.Flag{ Flags: []cli.Flag{
&cli.BoolFlag{Name: "dry-run", Usage: "Do not write to database"}, // TODO: &cli.BoolFlag{Name: "dry-run", Usage: "Do not write to database"}, // TODO:
&cli.StringFlag{Name: "log-directory", Usage: "Directory to watch for logs", Value: "/var/log/containers"}, &cli.StringFlag{Name: "log-directory", Usage: "Directory to watch for logs", Value: "/var/log/containers"},
@ -146,6 +147,7 @@ var App = &cli.App{
if !ok { if !ok {
return return
} }
// TODO: #1: || if not in filterset
if event.Op != fsnotify.Create { if event.Op != fsnotify.Create {
continue continue
} }

1
cmd/submit.go
View File

@ -111,6 +111,7 @@ func (s *submitter) shipFileRoutine(name string, sigCatchupped chan<- struct{})
} }
select { select {
// TODO: use per-file batch senders for file deletion mongo synced, and better error handling; #3
case s.sendQueue <- mLog{ case s.sendQueue <- mLog{
HostInfo: s.hostInfo, HostInfo: s.hostInfo,
Filename: *line.Filename, Filename: *line.Filename,