From f920d03bc8225b8d01deb927162a03e987875efb Mon Sep 17 00:00:00 2001 From: rasmus Date: Thu, 3 Nov 2022 12:42:59 +0200 Subject: [PATCH] add TODOs from gitea issues --- cmd/logmower.go | 2 ++ cmd/submit.go | 1 + 2 files changed, 3 insertions(+) diff --git a/cmd/logmower.go b/cmd/logmower.go index a1494da..d27c342 100644 --- a/cmd/logmower.go +++ b/cmd/logmower.go @@ -53,6 +53,7 @@ var App = &cli.App{ Description: "Collect and ship kubernetes logs", // Usage: "rubykana ", + // TODO: #2: yaml Flags: []cli.Flag{ &cli.BoolFlag{Name: "dry-run", Usage: "Do not write to database"}, // TODO: &cli.StringFlag{Name: "log-directory", Usage: "Directory to watch for logs", Value: "/var/log/containers"}, @@ -146,6 +147,7 @@ var App = &cli.App{ if !ok { return } + // TODO: #1: || if not in filterset if event.Op != fsnotify.Create { continue } diff --git a/cmd/submit.go b/cmd/submit.go index 7ab1b21..7396a8c 100644 --- a/cmd/submit.go +++ b/cmd/submit.go @@ -111,6 +111,7 @@ func (s *submitter) shipFileRoutine(name string, sigCatchupped chan<- struct{}) } select { + // TODO: use per-file batch senders for file deletion mongo synced, and better error handling; #3 case s.sendQueue <- mLog{ HostInfo: s.hostInfo, Filename: *line.Filename,