add retry logic to openrgb commands for boot-time stability

OpenRGB can crash (SIGABRT) during early boot when device enumeration
hasn't completed yet. Retry failed commands up to 4 times with a
3-second delay to let initialization finish.

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
This commit is contained in:
2026-04-15 16:22:27 +03:00
parent cdbd8abaa4
commit 182aa34008

View File

@@ -2,7 +2,14 @@ package openrgb
import ( import (
"fmt" "fmt"
"log"
"os/exec" "os/exec"
"time"
)
const (
maxRetries = 4
retryDelay = 3 * time.Second
) )
// Client controls RGB devices via the openrgb CLI. // Client controls RGB devices via the openrgb CLI.
@@ -29,21 +36,33 @@ func (c *Client) Close() error {
return nil return nil
} }
// run executes an openrgb command with retries to handle transient failures
// during early boot when device enumeration may not be complete.
func (c *Client) run(args ...string) error {
var lastErr error
for attempt := range maxRetries {
cmd := exec.Command(c.bin, args...)
out, err := cmd.CombinedOutput()
if err == nil {
return nil
}
lastErr = fmt.Errorf("openrgb %v: %w\n%s", args, err, out)
if attempt < maxRetries-1 {
log.Printf("openrgb command failed (attempt %d/%d), retrying in %v: %v",
attempt+1, maxRetries, retryDelay, lastErr)
time.Sleep(retryDelay)
}
}
return lastErr
}
// SetAllOff sets all devices to black (off) using direct mode. // SetAllOff sets all devices to black (off) using direct mode.
func (c *Client) SetAllOff() error { func (c *Client) SetAllOff() error {
cmd := exec.Command(c.bin, "--mode", "direct", "--color", "000000") return c.run("--mode", "direct", "--color", "000000")
if out, err := cmd.CombinedOutput(); err != nil {
return fmt.Errorf("openrgb set off: %w\n%s", err, out)
}
return nil
} }
// SetAllOn sets all devices to the given color. // SetAllOn sets all devices to the given color.
func (c *Client) SetAllOn(r, g, b byte) error { func (c *Client) SetAllOn(r, g, b byte) error {
color := fmt.Sprintf("%02X%02X%02X", r, g, b) color := fmt.Sprintf("%02X%02X%02X", r, g, b)
cmd := exec.Command(c.bin, "--mode", "direct", "--color", color) return c.run("--mode", "direct", "--color", color)
if out, err := cmd.CombinedOutput(); err != nil {
return fmt.Errorf("openrgb set on: %w\n%s", err, out)
}
return nil
} }