rawfile-localpv/metrics.py

from prometheus_client.core import REGISTRY
from prometheus_client.exposition import start_http_server


class VolumeStatsCollector(object):
    def collect(self):
        return []


def expose_metrics():
    REGISTRY.register(VolumeStatsCollector())
    start_http_server(9100)
Rewrite: Change the way we're exposing volume metrics Summary: Formerly, we were updating the metrics every 15 seconds. We were facing a couple of issues doing it manually: - Outdated metrics in case of a one-time crash - Metrics getting exposed for deleted PVs Instead of fixing the bugs, I preferred to do it the right way. As per `python-prometheus` docs: > Sometimes it is not possible to directly instrument code, as it is not in your control. This requires you to proxy metrics from other systems. To do so you need to create a custom collector... Test Plan: - Deploy on a cluster with existing rawfile PVs - Send request to `:9100/metrics` and assert that metrics are exposed - Delete a PV, and assert that its metrics disappear Reviewers: h.marvi, bghadiri, sina_rad, mhyousefi Reviewed By: h.marvi, bghadiri, sina_rad Differential Revision: https://phab.hamravesh.ir/D815 2020-06-12 11:25:32 +00:00			`from prometheus_client.core import REGISTRY`
Implement basic metrics 2020-04-25 19:39:16 +00:00			`from prometheus_client.exposition import start_http_server`


Expose volume metrics through gRPC calls rather than metrics endpoint 2021-01-15 23:15:31 +00:00			`class VolumeStatsCollector(object):`
			`def collect(self):`
			`return []`


Rewrite: Change the way we're exposing volume metrics Summary: Formerly, we were updating the metrics every 15 seconds. We were facing a couple of issues doing it manually: - Outdated metrics in case of a one-time crash - Metrics getting exposed for deleted PVs Instead of fixing the bugs, I preferred to do it the right way. As per `python-prometheus` docs: > Sometimes it is not possible to directly instrument code, as it is not in your control. This requires you to proxy metrics from other systems. To do so you need to create a custom collector... Test Plan: - Deploy on a cluster with existing rawfile PVs - Send request to `:9100/metrics` and assert that metrics are exposed - Delete a PV, and assert that its metrics disappear Reviewers: h.marvi, bghadiri, sina_rad, mhyousefi Reviewed By: h.marvi, bghadiri, sina_rad Differential Revision: https://phab.hamravesh.ir/D815 2020-06-12 11:25:32 +00:00			`def expose_metrics():`
			`REGISTRY.register(VolumeStatsCollector())`
Implement basic metrics 2020-04-25 19:39:16 +00:00			`start_http_server(9100)`