k-space/dex
Archived
10
0
Fork 0
Code Issues Pull Requests Packages Projects Activity

Merge pull request #1038 from xogroup/github-enterprise

Browse Source 
When connecting to GitHub Enterprise, force email verified field to true
This commit is contained in:
rithu leena john 2017-08-18 13:58:50 -07:00 committed by GitHub
commit e59d67f466
1 changed files with 14 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

14
connector/github/github.go
View File

@ -501,6 +501,20 @@ func (c *githubConnector) userEmail(ctx context.Context, client *http.Client) (s
} }
for _, email := range emails { for _, email := range emails {
/*
if GitHub Enterprise, set email.Verified to true
This change being made because GitHub Enterprise does not
support email verification. CircleCI indicated that GitHub
advised them not to check for verified emails
(https://circleci.com/enterprise/changelog/#1-47-1).
In addition, GitHub Enterprise support replied to a support
ticket with "There is no way to verify an email address in
GitHub Enterprise."
*/
if c.hostName != "" {
email.Verified = true
}
if email.Verified && email.Primary { if email.Verified && email.Primary {
return email.Email, nil return email.Email, nil
} }