From dcca42759221290cccda6d544acd07dc89d73edd Mon Sep 17 00:00:00 2001 From: Alex Suraci Date: Thu, 15 Nov 2018 11:27:20 -0500 Subject: [PATCH] fix bogus conformance failure due to time zones this failed on my machine due to the unexported 'loc' field of the time structure - it was nil in one and set to a ton of tiemzone data in the other. instead let's just compare the unix timestamp value and zero it out for the struct comparison. --- storage/conformance/conformance.go | 14 ++++++++++++++ 1 file changed, 14 insertions(+) diff --git a/storage/conformance/conformance.go b/storage/conformance/conformance.go index 5606def8..2f427971 100644 --- a/storage/conformance/conformance.go +++ b/storage/conformance/conformance.go @@ -341,6 +341,20 @@ func testRefreshTokenCRUD(t *testing.T, s storage.Storage) { t.Errorf("get refresh: %v", err) return } + + if diff := pretty.Compare(gr.CreatedAt.UnixNano(), gr.CreatedAt.UnixNano()); diff != "" { + t.Errorf("refresh token created timestamp retrieved from storage did not match: %s", diff) + } + + if diff := pretty.Compare(gr.LastUsed.UnixNano(), gr.LastUsed.UnixNano()); diff != "" { + t.Errorf("refresh token last used timestamp retrieved from storage did not match: %s", diff) + } + + gr.CreatedAt = time.Time{} + gr.LastUsed = time.Time{} + want.CreatedAt = time.Time{} + want.LastUsed = time.Time{} + if diff := pretty.Compare(want, gr); diff != "" { t.Errorf("refresh token retrieved from storage did not match: %s", diff) }