k-space/dex
Archived
10
0
Fork 0
Code Issues Pull Requests Packages Projects Activity

Merge pull request #817 from ericchiang/fix-hash-bug

Browse Source 
storage/kubernetes: fix hash initialization bug
This commit is contained in:
Eric Chiang 2017-02-24 12:58:22 -08:00 committed by GitHub
commit cd93930934
2 changed files with 17 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

7
storage/kubernetes/client.go
View File

@ -72,9 +72,10 @@ func idToName(s string, h func() hash.Hash) string {
} }
func offlineTokenName(userID string, connID string, h func() hash.Hash) string { func offlineTokenName(userID string, connID string, h func() hash.Hash) string {
h().Write([]byte(userID)) hash := h()
h().Write([]byte(connID)) hash.Write([]byte(userID))
return strings.TrimRight(encoding.EncodeToString(h().Sum(nil)), "=") hash.Write([]byte(connID))
return strings.TrimRight(encoding.EncodeToString(hash.Sum(nil)), "=")
} }
func (c *client) urlFor(apiVersion, namespace, resource, name string) string { func (c *client) urlFor(apiVersion, namespace, resource, name string) string {

13
storage/kubernetes/client_test.go
View File

@ -29,6 +29,19 @@ func TestIDToName(t *testing.T) {
wg.Wait() wg.Wait()
} }
func TestOfflineTokenName(t *testing.T) {
h := func() hash.Hash { return fnv.New64() }
userID1 := "john"
userID2 := "jane"
id1 := offlineTokenName(userID1, "local", h)
id2 := offlineTokenName(userID2, "local", h)
if id1 == id2 {
t.Errorf("expected offlineTokenName to produce different hashes")
}
}
func TestNamespaceFromServiceAccountJWT(t *testing.T) { func TestNamespaceFromServiceAccountJWT(t *testing.T) {
namespace, err := namespaceFromServiceAccountJWT(serviceAccountToken) namespace, err := namespaceFromServiceAccountJWT(serviceAccountToken)
if err != nil { if err != nil {