Merge pull request #740 from ericchiang/fix-comment-typos
*: fix comment typos and add go report card icon
This commit is contained in:
commit
91cc94dd8f
@ -2,6 +2,7 @@
|
|||||||
|
|
||||||
[![Travis](https://api.travis-ci.org/coreos/dex.svg)](https://travis-ci.org/coreos/dex)
|
[![Travis](https://api.travis-ci.org/coreos/dex.svg)](https://travis-ci.org/coreos/dex)
|
||||||
[![GoDoc](https://godoc.org/github.com/coreos/dex?status.svg)](https://godoc.org/github.com/coreos/dex)
|
[![GoDoc](https://godoc.org/github.com/coreos/dex?status.svg)](https://godoc.org/github.com/coreos/dex)
|
||||||
|
[![Go Report Card](https://goreportcard.com/badge/github.com/coreos/dex)](https://goreportcard.com/report/github.com/coreos/dex)
|
||||||
|
|
||||||
![logo](Documentation/logos/dex-horizontal-color.png)
|
![logo](Documentation/logos/dex-horizontal-color.png)
|
||||||
|
|
||||||
|
@ -70,7 +70,7 @@ func renderTemplate(w http.ResponseWriter, tmpl *template.Template, data interfa
|
|||||||
|
|
||||||
switch err := err.(type) {
|
switch err := err.(type) {
|
||||||
case *template.Error:
|
case *template.Error:
|
||||||
// An ExecError guarentees that Execute has not written to the underlying reader.
|
// An ExecError guarantees that Execute has not written to the underlying reader.
|
||||||
log.Printf("Error rendering template %s: %s", tmpl.Name(), err)
|
log.Printf("Error rendering template %s: %s", tmpl.Name(), err)
|
||||||
|
|
||||||
// TODO(ericchiang): replace with better internal server error.
|
// TODO(ericchiang): replace with better internal server error.
|
||||||
|
@ -13,7 +13,7 @@ import (
|
|||||||
"github.com/coreos/dex/version"
|
"github.com/coreos/dex/version"
|
||||||
)
|
)
|
||||||
|
|
||||||
// apiVersion increases everytime a new call is added to the API. Clients should use this info
|
// apiVersion increases every time a new call is added to the API. Clients should use this info
|
||||||
// to determine if the server supports specific features.
|
// to determine if the server supports specific features.
|
||||||
const apiVersion = 0
|
const apiVersion = 0
|
||||||
|
|
||||||
|
@ -222,7 +222,7 @@ func (t *templates) oob(w http.ResponseWriter, code string) error {
|
|||||||
return renderTemplate(w, t.oobTmpl, data)
|
return renderTemplate(w, t.oobTmpl, data)
|
||||||
}
|
}
|
||||||
|
|
||||||
// small io.Writer utilitiy to determine if executing the template wrote to the underlying response writer.
|
// small io.Writer utility to determine if executing the template wrote to the underlying response writer.
|
||||||
type writeRecorder struct {
|
type writeRecorder struct {
|
||||||
wrote bool
|
wrote bool
|
||||||
w io.Writer
|
w io.Writer
|
||||||
|
@ -62,7 +62,7 @@ func mustLoadJWK(b string) *jose.JSONWebKey {
|
|||||||
func mustBeErrNotFound(t *testing.T, kind string, err error) {
|
func mustBeErrNotFound(t *testing.T, kind string, err error) {
|
||||||
switch {
|
switch {
|
||||||
case err == nil:
|
case err == nil:
|
||||||
t.Errorf("deleting non-existant %s should return an error", kind)
|
t.Errorf("deleting non-existent %s should return an error", kind)
|
||||||
case err != storage.ErrNotFound:
|
case err != storage.ErrNotFound:
|
||||||
t.Errorf("deleting %s expected storage.ErrNotFound, got %v", kind, err)
|
t.Errorf("deleting %s expected storage.ErrNotFound, got %v", kind, err)
|
||||||
}
|
}
|
||||||
|
@ -13,7 +13,7 @@ import (
|
|||||||
)
|
)
|
||||||
|
|
||||||
// TODO(ericchiang): The update, insert, and select methods queries are all
|
// TODO(ericchiang): The update, insert, and select methods queries are all
|
||||||
// very repetivite. Consider creating them programatically.
|
// very repetitive. Consider creating them programmatically.
|
||||||
|
|
||||||
// keysRowID is the ID of the only row we expect to populate the "keys" table.
|
// keysRowID is the ID of the only row we expect to populate the "keys" table.
|
||||||
const keysRowID = "keys"
|
const keysRowID = "keys"
|
||||||
|
Reference in New Issue
Block a user