From 4812079647c358a18696d96220183a62605cd0c9 Mon Sep 17 00:00:00 2001
From: Rui Yang <ruiya@vmware.com>
Date: Tue, 4 Aug 2020 15:39:03 -0400
Subject: [PATCH] add tests when preferred username key is not set

Signed-off-by: Rui Yang <ruiya@vmware.com>
---
 connector/oidc/oidc_test.go | 47 ++++++++++++++++++++++++++++---------
 1 file changed, 36 insertions(+), 11 deletions(-)

diff --git a/connector/oidc/oidc_test.go b/connector/oidc/oidc_test.go
index 1515e0ad..b5c717b9 100644
--- a/connector/oidc/oidc_test.go
+++ b/connector/oidc/oidc_test.go
@@ -85,18 +85,16 @@ func TestHandleCallback(t *testing.T) {
 			},
 		},
 		{
-			name:                    "withUserIDKey",
-			userIDKey:               "name",
-			expectUserID:            "namevalue",
-			expectUserName:          "namevalue",
-			expectPreferredUsername: "usernamevalue",
-			expectedEmailField:      "emailvalue",
+			name:               "withUserIDKey",
+			userIDKey:          "name",
+			expectUserID:       "namevalue",
+			expectUserName:     "namevalue",
+			expectedEmailField: "emailvalue",
 			token: map[string]interface{}{
-				"sub":                "subvalue",
-				"name":               "namevalue",
-				"preferred_username": "usernamevalue",
-				"email":              "emailvalue",
-				"email_verified":     true,
+				"sub":            "subvalue",
+				"name":           "namevalue",
+				"email":          "emailvalue",
+				"email_verified": true,
 			},
 		},
 		{
@@ -127,6 +125,33 @@ func TestHandleCallback(t *testing.T) {
 				"email_verified": true,
 			},
 		},
+		{
+			name:                    "withoutPreferredUsernameKeyAndBackendReturns",
+			expectUserID:            "subvalue",
+			expectUserName:          "namevalue",
+			expectPreferredUsername: "preferredusernamevalue",
+			expectedEmailField:      "emailvalue",
+			token: map[string]interface{}{
+				"sub":                "subvalue",
+				"name":               "namevalue",
+				"preferred_username": "preferredusernamevalue",
+				"email":              "emailvalue",
+				"email_verified":     true,
+			},
+		},
+		{
+			name:                    "withoutPreferredUsernameKeyAndBackendNotReturn",
+			expectUserID:            "subvalue",
+			expectUserName:          "namevalue",
+			expectPreferredUsername: "",
+			expectedEmailField:      "emailvalue",
+			token: map[string]interface{}{
+				"sub":            "subvalue",
+				"name":           "namevalue",
+				"email":          "emailvalue",
+				"email_verified": true,
+			},
+		},
 		{
 			name:                      "emptyEmailScope",
 			expectUserID:              "subvalue",