Discard package "version" (#2107)
* Discard package "version" Signed-off-by: m.nabokikh <maksim.nabokikh@flant.com> * Inject api version Signed-off-by: m.nabokikh <maksim.nabokikh@flant.com> * Pass version arg to the dex API Signed-off-by: m.nabokikh <maksim.nabokikh@flant.com>
This commit is contained in:
@@ -11,7 +11,6 @@ import (
|
||||
"github.com/dexidp/dex/pkg/log"
|
||||
"github.com/dexidp/dex/server/internal"
|
||||
"github.com/dexidp/dex/storage"
|
||||
"github.com/dexidp/dex/version"
|
||||
)
|
||||
|
||||
// apiVersion increases every time a new call is added to the API. Clients should use this info
|
||||
@@ -30,18 +29,20 @@ const (
|
||||
)
|
||||
|
||||
// NewAPI returns a server which implements the gRPC API interface.
|
||||
func NewAPI(s storage.Storage, logger log.Logger) api.DexServer {
|
||||
func NewAPI(s storage.Storage, logger log.Logger, version string) api.DexServer {
|
||||
return dexAPI{
|
||||
s: s,
|
||||
logger: logger,
|
||||
s: s,
|
||||
logger: logger,
|
||||
version: version,
|
||||
}
|
||||
}
|
||||
|
||||
type dexAPI struct {
|
||||
api.UnimplementedDexServer
|
||||
|
||||
s storage.Storage
|
||||
logger log.Logger
|
||||
s storage.Storage
|
||||
logger log.Logger
|
||||
version string
|
||||
}
|
||||
|
||||
func (d dexAPI) CreateClient(ctx context.Context, req *api.CreateClientReq) (*api.CreateClientResp, error) {
|
||||
@@ -223,7 +224,7 @@ func (d dexAPI) DeletePassword(ctx context.Context, req *api.DeletePasswordReq)
|
||||
|
||||
func (d dexAPI) GetVersion(ctx context.Context, req *api.VersionReq) (*api.VersionResp, error) {
|
||||
return &api.VersionResp{
|
||||
Server: version.Version,
|
||||
Server: d.version,
|
||||
Api: apiVersion,
|
||||
}, nil
|
||||
}
|
||||
|
@@ -36,7 +36,7 @@ func newAPI(s storage.Storage, logger log.Logger, t *testing.T) *apiClient {
|
||||
}
|
||||
|
||||
serv := grpc.NewServer()
|
||||
api.RegisterDexServer(serv, NewAPI(s, logger))
|
||||
api.RegisterDexServer(serv, NewAPI(s, logger, "test"))
|
||||
go serv.Serve(l)
|
||||
|
||||
// Dial will retry automatically if the serv.Serve() goroutine
|
||||
|
Reference in New Issue
Block a user