Refactor member fields to nested form #3

Merged
lauri merged 1 commits from madis/dev-mongo:master into master 2021-10-15 17:46:12 +00:00
Owner
No description provided.
madis added 1 commit 2021-10-07 12:36:23 +00:00
madis requested review from lauri 2021-10-07 12:36:42 +00:00
Owner

Can you please use same field names as in the object being nested? (id and full_name)

Can you please use same field names as in the object being nested? (`id` and `full_name`)
Author
Owner

I thought about it and i think it would be better to have the same field names in every object we store like this. It would allow to keep code like the search filter generic.

I thought about it and i think it would be better to have the same field names in every object we store like this. It would allow to keep code like the search filter generic.
Author
Owner

But if you are sure then yes, i can do id and full_name

But if you are sure then yes, i can do id and full_name
Author
Owner

To clarify, if for example we will also have references back to the inventory collection, it would be nice to be able to handle them the same way. We should keep the same convention in all nested references and full_name would make less sense for inventory.

Please confirm if you still want to use id and full_name or not.

To clarify, if for example we will also have references back to the inventory collection, it would be nice to be able to handle them the same way. We should keep the same convention in all nested references and full_name would make less sense for inventory. Please confirm if you still want to use id and full_name or not.
lauri merged commit 4b553db457 into master 2021-10-15 17:46:12 +00:00
Sign in to join this conversation.
No reviewers
No Label
No Milestone
No project
No Assignees
2 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: k-space/dev-mongo#3
No description provided.